Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RowVector obey AbstractMatrix indexing interface #23706

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Make RowVector obey AbstractMatrix indexing interface #23706

merged 1 commit into from
Sep 15, 2017

Conversation

andyferris
Copy link
Member

@andyferris andyferris added arrays [a, r, r, a, y, s] backport pending 0.6 bugfix This change fixes an existing bug labels Sep 14, 2017
@StefanKarpinski
Copy link
Member

Love the code reduction and simplification! ❤️

@andreasnoack andreasnoack merged commit b9aed45 into master Sep 15, 2017
@andreasnoack andreasnoack deleted the ajf/rowvector-indexing branch September 15, 2017 07:40
ararslan pushed a commit that referenced this pull request Nov 7, 2017
@andyferris @ararslan
Make RowVector obey AbstractMatrix indexing interface (#23706)
8d07564 
Fixes #23649

(cherry picked from commit b9aed45)
ararslan pushed a commit that referenced this pull request Nov 8, 2017
@andyferris @ararslan
Make RowVector obey AbstractMatrix indexing interface (#23706)
d1c21f7 
Fixes #23649

(cherry picked from commit b9aed45)
ararslan pushed a commit that referenced this pull request Nov 14, 2017
@andyferris @ararslan
Make RowVector obey AbstractMatrix indexing interface (#23706)
cca2e70 
Fixes #23649

(cherry picked from commit b9aed45)
@ararslan
Copy link
Member

git bisect says that backporting this broke the ImageFiltering tests. See https://gist.github.com/ararslan/ae2efe715bbc9357ea0a3f501d30b2b0#file-pkgeval_imagefiltering_test-log. Looks like it's hitting a getindex method here.

@ararslan ararslan mentioned this pull request Nov 21, 2017
Merged
@andyferris
Copy link
Member Author

@ararslan not too surprising something was affected by this...

@ararslan
Copy link
Member

Is there a way to fix the Diagonal segfault in a non-breaking way in 0.6? Otherwise I think I have to just remove this commit from my backports branch.

@dkarrasch dkarrasch mentioned this pull request Nov 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasnoack andreasnoack andreasnoack approved these changes

Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s] bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diagonal(RowVector) segfaults
4 participants
@andyferris @StefanKarpinski @ararslan @andreasnoack