Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate readcsv in favor of readdlm #23530

Merged
merged 2 commits into from
Sep 9, 2017
Merged

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Aug 31, 2017

This pull request deprecates readcsv(io[, T::Type]; opts...) in favor of readdlm(io, ','[, T]; opts...), addressing part of #23414. Best!

@Sacha0 Sacha0 added deprecation This change introduces or involves a deprecation io Involving the I/O subsystem: libuv, read, write, etc. labels Aug 31, 2017
@Sacha0 Sacha0 added this to the 1.0 milestone Aug 31, 2017
@dpsanders
Copy link
Contributor

Isn't readcsv a more obvious name than readdlm?

@JeffBezanson
Copy link
Member

That's the problem. You shouldn't use this function, because a far better implementation exists in a package.

@dpsanders
Copy link
Contributor

dpsanders commented Aug 31, 2017 via email

@StefanKarpinski
Copy link
Member

I meant that the name readdlm is hard to discover and hard to remember.

True. I'm all for deleting readdlm as well.

@ViralBShah
Copy link
Member

ViralBShah commented Sep 2, 2017

So, just to load some simple files in Base, one has to go mucking with packages? If the name readdlm is hard to discover, it makes sense to rename it with something better. However, I don't understand this obsession with deleting everything from Base.

@JeffBezanson JeffBezanson merged commit 368bb49 into JuliaLang:master Sep 9, 2017
@Sacha0
Copy link
Member Author

Sacha0 commented Sep 12, 2017

Thanks all! :)

@Sacha0 Sacha0 deleted the depreadcsv branch September 12, 2017 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This change introduces or involves a deprecation io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants