Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last docstrings for LibGit2 GitIndex #23395

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Last docstrings for LibGit2 GitIndex #23395

merged 1 commit into from
Aug 23, 2017

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Aug 22, 2017

No description provided.

@kshyatt kshyatt added docs This change adds or pertains to documentation libgit2 The libgit2 library or the LibGit2 stdlib module labels Aug 22, 2017
@kshyatt kshyatt requested a review from ararslan August 22, 2017 19:25
@kshyatt kshyatt mentioned this pull request Aug 22, 2017
Closed
ararslan
ararslan approved these changes Aug 22, 2017
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though a little more detail on remove! might be nice. It's not immediately clear to me in what sense it's being removed, but that might just be me.

@kshyatt kshyatt merged commit ecdfdb7 into master Aug 23, 2017
@kshyatt kshyatt deleted the ksh/docind branch August 23, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kshyatt @ararslan