Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix repl completions on unions and Any #23345

Merged
merged 1 commit into from
Aug 22, 2017

Conversation

KristofferC
Copy link
Member

Fix #23284

@KristofferC
Copy link
Member Author

The circleci test failure is weird:

Error in testset statistics:
Error During Test
  Got an exception of type LoadError outside of a @test
  LoadError: return type RowVector{Float64,Array{Float64,1}} does not match inferred return type Any
  Stacktrace:
   [1] abstract_call(::Any, ::Tuple{}, ::Array{Any,1}, ::Array{Any,1}, ::Core.Inference.InferenceState) at ./inference.jl:2285
   [2] finddoc(::Base.Docs.##9#11{String,Bool}, ::Expr) at ./docs/Docs.jl:632
  while loading /tmp/julia/share/julia/test/statistics.jl, in expression starting on line 177
ERROR: LoadError: Test run finished with errors
while loading /tmp/julia/share/julia/test/runtests.jl, in expression starting on line 29

Dont think it is related to this PR?

@fredrikekre
Copy link
Member

Same error in #23341

@kshyatt kshyatt added the REPL Julia's REPL (Read Eval Print Loop) label Aug 20, 2017
@KristofferC
Copy link
Member Author

Anyone feel like looking over this?

@StefanKarpinski
Copy link
Member

What does it need? Does it pass tests at this point or no?

@KristofferC
Copy link
Member Author

It needs review.

@StefanKarpinski
Copy link
Member

It looks reasonable to me, but I don't really understand what it's doing, so if it fixes the problem, passes tests and doesn't seem to break things, then we can just merge it. Otherwise, you'll need to propose someone who understands this code to review it.

@KristofferC KristofferC merged commit f7d16c6 into master Aug 22, 2017
@KristofferC KristofferC deleted the kc/fix_complete_type_unstable branch August 22, 2017 18:54
@rfourquet
Copy link
Member

A bit late, but LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants