Misc remove &x ccall syntax
#23301
Merged
Misc remove &x ccall syntax
#23301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
reviewed
Aug 17, 2017
base/irrationals.jl
Outdated
| ccall(($(string("mpfr_const_", def)), :libmpfr), | ||
| Cint, (Ref{BigFloat}, Int32), c, MPFR.ROUNDING_MODE[]) | ||
| return c | ||
| return c[] |
There was a problem hiding this comment.
I am following the suggestion here JuliaMath/SpecialFunctions.jl#44 (comment) isn't this more explicit and clear ?
There was a problem hiding this comment.
The Ref is not doing anything and you ARE mutating the BigFloat so adding a Ref seems like a bad idea.
There was a problem hiding this comment.
OK thank you very much for clarifying this! Droped the last commit. Other than that is this LGTY?
yuyichao
requested changes
Aug 17, 2017
base/printf.jl
Outdated
| @@ -1130,8 +1130,8 @@ function bigfloat_printf(out, d, flags::String, width::Int, precision::Int, c::C | |||
| @assert length(printf_fmt) == fmt_len | |||
| bufsiz = length(DIGITS) | |||
| lng = ccall((:mpfr_snprintf,:libmpfr), Int32, | |||
| (Ptr{UInt8}, Culong, Ptr{UInt8}, Ptr{BigFloat}...), | |||
| DIGITS, bufsiz, printf_fmt, &d) | |||
| (Ptr{UInt8}, Culong, Ptr{UInt8}, Ref{BigFloat}), | |||
There was a problem hiding this comment.
Keep the ... It can affect calling convention (and does on x86_64).
yuyichao
approved these changes
Aug 17, 2017
|
Thanks for the review @yuyichao |
|
part of #6080 (ref) |
|
good to merge? |
rfourquet
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.