RFC: preserve more syntax in parsing ?, do, and elseif
#23061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
breaking
tkelman
reviewed
Aug 1, 2017
| @@ -13,13 +13,13 @@ such as a `ccall` to a non-existent function. | |||
| """ | |||
| macro static(ex) | |||
| if isa(ex, Expr) | |||
| if ex.head === :if || ex.head === :&& || ex.head === :|| | |||
| if ex.head === :if || ex.head === :&& || ex.head === :|| || ex.head === :? | |||
There was a problem hiding this comment.
should @static also statically resolve elseif conditions?
There was a problem hiding this comment.
It could, but that would be more of a new feature, since it was never able to before.
|
does Line 419 in 7233d7d |
|
Yes, it should be updated for |
|
@nanosoldier |
|
I will break this into smaller PRs. |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
|
It's TOO LATE, Nanosoldier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #21774 that I find pretty agreeable.
?- just uses?as the expression head instead ofifdoparses as(do <function call expr> <function argument expr>)ifparses the same as before, except nestedifs that come fromelseifuseelseifas the expression head instead ofif, and are nested directly inside theifexpression without intervening blocks, line nodes, etc. I also tried a flat representation (adding N arguments toif), but it was hard to deal with. The nested structure is easier since you only need to write code to handle 2- or 3-argumentif, and treatelseifthe same asif.This should be non-breaking for users, and a living nightmare for macro authors :)