Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #17240, evaluate keyword argument defaults in successive scopes #22958

Merged
merged 1 commit into from
Jul 26, 2017
Merged

fix #17240, evaluate keyword argument defaults in successive scopes #22958

merged 1 commit into from
Jul 26, 2017

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added the keyword arguments f(x; keyword=arguments) label Jul 25, 2017
@JeffBezanson
fix #17240, evaluate keyword argument defaults in successive scopes
0af919b 
This matches the behavior of optional positional arguments.
@tkelman
Copy link
Contributor

tkelman commented Jul 26, 2017

hopefully no change, but just in case @nanosoldier runbenchmarks(ALL, vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@JeffBezanson JeffBezanson merged commit 8ebedd6 into master Jul 26, 2017
@JeffBezanson JeffBezanson deleted the jb/fix17240 branch July 26, 2017 20:26
@StefanKarpinski StefanKarpinski mentioned this pull request Aug 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
keyword arguments f(x; keyword=arguments)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeffBezanson @tkelman @nanosoldier @StefanKarpinski