Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Upper/LowerTriangular #22504

Merged
merged 1 commit into from
Jun 24, 2017
Merged

Document Upper/LowerTriangular #22504

merged 1 commit into from
Jun 24, 2017

Conversation

fredrikekre
Copy link
Member

Document UpperTriangular/LowerTriangular and clarify that Symmetric/Hermitian are views of the underlying matrix as well.

@fredrikekre
Copy link
Member Author

Failure is #22472 (comment)

@tkelman
Copy link
Contributor

tkelman commented Jun 24, 2017

We didn't have this yet? LGTM

KristofferC
KristofferC reviewed Jun 24, 2017
View reviewed changes
base/linalg/symmetric.jl Outdated
@@ -49,7 +50,8 @@ end
"""
Hermitian(A, uplo=:U)

Construct a `Hermitian` matrix from the upper (if `uplo = :U`) or lower (if `uplo = :L`) triangle of `A`.
Construct a `Hermitian` view from the upper (if `uplo = :U`) or lower (if `uplo = :L`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is best, "from the upper" or "of the upper"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"of the upper" maybe?

@fredrikekre
document Upper/LowerTriangular
c964958 
and clarify that Symmetric/Hermitian are views as well

add references to Upper/LowerTriangular in the manual
Sacha0
Sacha0 approved these changes Jun 24, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! :)

@kshyatt kshyatt added docs This change adds or pertains to documentation linear algebra Linear algebra labels Jun 24, 2017
@kshyatt kshyatt merged commit 93e816a into JuliaLang:master Jun 24, 2017
@fredrikekre
Copy link
Member Author

Thanks!

@fredrikekre fredrikekre deleted the fe/view branch June 25, 2017 02:14
ararslan pushed a commit that referenced this pull request Sep 11, 2017
@kshyatt @ararslan
Merge pull request #22504 from fredrikekre/fe/view
5c36d23 
Document Upper/LowerTriangular

Ref #22504
(cherry picked from commit 93e816a)
ararslan pushed a commit that referenced this pull request Sep 13, 2017
@fredrikekre @ararslan
document Upper/LowerTriangular
42f5758 
and clarify that Symmetric/Hermitian are views as well

add references to Upper/LowerTriangular in the manual

Ref #22504
(cherry picked from commit c964958)
vtjnash pushed a commit that referenced this pull request Sep 14, 2017
@fredrikekre @vtjnash
document Upper/LowerTriangular
36309c2 
and clarify that Symmetric/Hermitian are views as well

add references to Upper/LowerTriangular in the manual

Ref #22504
(cherry picked from commit c964958)
ararslan pushed a commit that referenced this pull request Sep 15, 2017
@fredrikekre @ararslan
document Upper/LowerTriangular
cdb5335 
and clarify that Symmetric/Hermitian are views as well

add references to Upper/LowerTriangular in the manual

Ref #22504
(cherry picked from commit c964958)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC approved these changes

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fredrikekre @tkelman @KristofferC @Sacha0 @kshyatt @ararslan