Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove false statement about convert on types #22300

Closed
wants to merge 1 commit into from
Closed

remove false statement about convert on types #22300

wants to merge 1 commit into from

Conversation

KristofferC
Copy link
Sponsor Member

@KristofferC KristofferC added the domain:docs This change adds or pertains to documentation label Jun 8, 2017
@nalimilan
Copy link
Member

Rather than removing this paragraph, shouldn't it be restricted to one-argument constructors? Given the confusion this generates, the fallback should really be described in detail (so that it doesn't need to be repeated on Discourse).

@stevengj
Copy link
Member

stevengj commented Jun 9, 2017 •
edited
Loading

The fallback, and the circumstances where you would define convert rather than a constructor, definitely needs to be documented.

@kshyatt kshyatt added the domain:types and dispatch Types, subtyping and method dispatch label Jun 21, 2017
@helgee
Copy link
Contributor

helgee commented Jun 22, 2017

Related: #15120

@vtjnash vtjnash mentioned this pull request Aug 22, 2017
Merged
@JeffBezanson
Copy link
Sponsor Member

This is handled by #23273

@DilumAluthge DilumAluthge deleted the KristofferC-patch-1 branch March 25, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:docs This change adds or pertains to documentation domain:types and dispatch Types, subtyping and method dispatch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KristofferC @nalimilan @stevengj @helgee @JeffBezanson @kshyatt