Inline some shift operators #22083
Merged
Inline some shift operators #22083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inline some shift operators
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
|
surprised the speedup isn't visible in those results, isn't this operation already covered in existing benchmarks? |
|
No, it doesn't seem like it. |
|
Benchmark tag added to #21241 |
tkelman
pushed a commit
that referenced
this pull request
Jun 3, 2017
inline some shift operators (cherry picked from commit 2c73e9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21241 (checked that performance is fixed).
Don't have time to do a full BaseBenchmarks.jl test right now but tentatively putting a backport label.