Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scope rules: implicitly using a global doesn't add it to the scope #22061

Merged
merged 1 commit into from
May 31, 2017
Merged

fix scope rules: implicitly using a global doesn't add it to the scope #22061

merged 1 commit into from
May 31, 2017

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented May 25, 2017

fix #21900

@vtjnash vtjnash merged commit bc606f6 into master May 31, 2017
@vtjnash vtjnash deleted the jn/scope-bugfix branch May 31, 2017 05:42
tkelman
tkelman reviewed May 31, 2017
View reviewed changes
test/core.jl
function f7234_b()
global f7234_cnt += 1
glob_x2 += 1
global f7235_cnt += -10000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to say 7234?

did anyone review this?

tkelman pushed a commit that referenced this pull request Jun 3, 2017
@vtjnash @tkelman
fix scope rules: implicitly using a global doesn't add it to the scope
341364f 
fix #21900

(cherry picked from commit 3900e33)
ref #22061
This was referenced Jun 7, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman left review comments

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

@yuyichao yuyichao Awaiting requested review from yuyichao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vtjnash @tkelman