Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix jl_gc_realloc_string size miscomputation #22044

Merged
merged 1 commit into from
May 24, 2017
Merged

fix jl_gc_realloc_string size miscomputation #22044

merged 1 commit into from
May 24, 2017

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented May 23, 2017

fix #22021

@vtjnash vtjnash requested a review from yuyichao May 23, 2017 21:17
@WestleyArgentum
Copy link
Member

+10000 Works locally here!

yuyichao
yuyichao approved these changes May 23, 2017
View reviewed changes
Copy link
Contributor

@yuyichao yuyichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this actually doesn't have any performance advantage, only smaller allocation count since we count realloc differently than free and alloc, even though the latter is actually what's happening....

@vtjnash vtjnash merged commit a78978e into master May 24, 2017
@vtjnash vtjnash deleted the jn/22021 branch May 24, 2017 00:48
@alyst
Copy link
Contributor

alyst commented May 24, 2017

Would be nice to add the test for the bug.

@martinholters martinholters added the needs tests Unit tests are required for this change label May 24, 2017
@alyst alyst mentioned this pull request May 24, 2017
Merged
@tkelman tkelman removed the needs tests Unit tests are required for this change label Jun 2, 2017
@tkelman
Copy link
Contributor

tkelman commented Jun 2, 2017

#22196 opened to add a test

@tkelman tkelman mentioned this pull request Jun 3, 2017
Merged
tkelman pushed a commit that referenced this pull request Jun 3, 2017
@vtjnash @tkelman
fix jl_gc_realloc_string size miscomputation
544694a 
fix #22021

(cherry picked from commit df3cd1c)
ref #22044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyichao yuyichao yuyichao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add test for: Problem with join
6 participants
@vtjnash @WestleyArgentum @alyst @tkelman @yuyichao @martinholters