-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #22029
Update README.md #22029
Conversation
Fixed broken link.
I gather this will be fixed by JuliaDocs/Documenter.jl#485 but right now, the link is broken and I was suggested to make a PR. |
README.md
Outdated
@@ -427,4 +427,4 @@ is available through | |||
[Sublime-IJulia](https://github.com/quinnj/Sublime-IJulia) plugin | |||
enables interaction between IJulia and Sublime Text. | |||
|
|||
In the terminal, Julia makes great use of both control-key and meta-key bindings. To make the meta-key bindings more accessible, many terminal emulator programs (e.g., `Terminal`, `iTerm`, `xterm`, etc.) allow you to use the alt or option key as meta. See the section in the manual on [interacting with Julia](https://docs.julialang.org/en/latest/manual/interacting-with-julia/) for more details. | |||
In the terminal, Julia makes great use of both control-key and meta-key bindings. To make the meta-key bindings more accessible, many terminal emulator programs (e.g., `Terminal`, `iTerm`, `xterm`, etc.) allow you to use the alt or option key as meta. See the section in the manual on [interacting with Julia](https://docs.julialang.org/en/latest/manual/interacting-with-julia.html) for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with the version without the trailing .html
– i.e. just delete the trailing slash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that it works that way, I didn't know that. I think using subdirectories would still preferred, since then it works with both trailing slashes and without.
As a related side note, I would love to get a Documenter version with that PR into 0.6 as well, so that we wouldn't have the .html
s in manual URLs for a stable release. Just needs a minor release on my part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I 100% agree – would you be willing to change it so that it works with or without the trailing /
? This has bothered me on a number of other occasions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just coordinate with @tkelman on making sure the change gets into the next RC, which is hopefully the last one for 0.6...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #22048 just for that a few hours ago 😄
Thank you! |
Ooops, should have squashed that 🤷♂️ |
Squashed what? |
Two commits into a single one. No worries, thanks for the fix! |
Fixed broken link.