Patch to further fix building julia with llvm-svn #22015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
reviewed
May 22, 2017
src/llvm-lower-handlers.cpp
Outdated
| @@ -107,15 +107,22 @@ static void ensure_enter_function(Module &M) | |||
| } | |||
|
|
|||
| bool LowerExcHandlers::doInitialization(Module &M) { | |||
| auto T_pint8 = Type::getInt8PtrTy(M.getContext(), 0) | |||
There was a problem hiding this comment.
Missing semicolon and wierd indent...
There was a problem hiding this comment.
Can also go into the if JL_LLVM_VERSION block below.
ararslan
added
building
Keno
requested changes
May 22, 2017
src/llvm-lower-handlers.cpp
Outdated
| @@ -107,15 +107,22 @@ static void ensure_enter_function(Module &M) | |||
| } | |||
|
|
|||
| bool LowerExcHandlers::doInitialization(Module &M) { | |||
| auto T_pint8 = Type::getInt8PtrTy(M.getContext(), 0) | |||
There was a problem hiding this comment.
Can also go into the if JL_LLVM_VERSION block below.
src/llvm-lower-handlers.cpp
Outdated
| lifetime_end = Intrinsic::getDeclaration(&M, Intrinsic::lifetime_end); | ||
|
|
||
| #if JL_LLVM_VERSION >= 50000 | ||
| auto lifetime_start = Intrinsic::getDeclaration(&M, Intrinsic::lifetime_start, { T_pint8 }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21720 (comment) but still doesn't fix the DICompile issue in #21879 (Credits: @Keno)