Only try to call specialized findin method for sorted input when elements are Real. #22010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
May 21, 2017
base/array.jl
Outdated
| @@ -1791,13 +1791,16 @@ julia> findin(a,b) # 10 is the only common element | |||
| 4 | |||
| ``` | |||
| """ | |||
| function findin(a, b) | |||
| function findin(a::Array{<:Real}, b::Union{Array{<:Real,Real}}) | |||
There was a problem hiding this comment.
I don't understand the union here. Did you mean Union{Array{<:Real}, Real}? Otherwise this is Array{T, Real} where T<:Real.
There was a problem hiding this comment.
You are right. It is a typo.
elements are Real.
Use total order `isless` for tests Add tests
|
I've updated this PR with fixes to the algorithm for the issue pointed out in #21934 (comment) and added tests. I had to define |
tkelman
reviewed
May 22, 2017
base/array.jl
Outdated
| @@ -1734,6 +1734,9 @@ function _findin(a, b) | |||
| ind | |||
| end | |||
|
|
|||
| # If two collections are already sorted, findin can be computed with | |||
| # a single traversal of the two collections. This is much fast than | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should handle the issue mentioned in #21934 (comment). Eventually, we might want to handle this in a smarter way. See #21999.