Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #21906, ccall causes unnecessary variable Box #21911

Merged
merged 1 commit into from
May 17, 2017
Merged

fix #21906, ccall causes unnecessary variable Box #21911

merged 1 commit into from
May 17, 2017

Conversation

JeffBezanson
Copy link
Member

This was probably an oversight from when the foreigncall expr head was introduced.

@JeffBezanson JeffBezanson added backport pending 0.6 compiler:lowering Syntax lowering (compiler front end, 2nd stage) multithreading Base.Threads and related functionality performance Must go faster labels May 16, 2017
@tkelman
Copy link
Contributor

tkelman commented May 17, 2017

@nanosoldier runbenchmarks(ALL, vs=":master")

tkelman pushed a commit that referenced this pull request May 17, 2017
@JeffBezanson @tkelman
fix #21906, ccall causes unnecessary variable Box
be004c1 
(cherry picked from commit 18562e0)
ref #21911
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@JeffBezanson JeffBezanson merged commit cff2d75 into master May 17, 2017
@JeffBezanson JeffBezanson deleted the jb/fix21906 branch May 17, 2017 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compiler:lowering Syntax lowering (compiler front end, 2nd stage) multithreading Base.Threads and related functionality performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeffBezanson @tkelman @nanosoldier