Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use where syntax in umfpack.jl #21890

Merged
merged 3 commits into from
May 17, 2017
Merged

Use where syntax in umfpack.jl #21890

merged 3 commits into from
May 17, 2017

Conversation

musm
Copy link
Contributor

@musm musm commented May 15, 2017

No description provided.

Sacha0
Sacha0 approved these changes May 15, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @musm! :) (Absent objections, requests for time, or someone beating me to it, I plan to merge this tomorrow morning.)

@tkelman
Copy link
Contributor

tkelman commented May 15, 2017

will conflict with #21889, which should be higher priority

@Sacha0
Copy link
Member

Sacha0 commented May 16, 2017

Rebase with #21889 in? :)

Sacha0
Sacha0 approved these changes May 16, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the rebased version! :) (Absent objections, requests for time, or someone beating me to it, I plan to merge this later today.)

tkelman
tkelman reviewed May 16, 2017
View reviewed changes
base/sparse/umfpack.jl Outdated
_Aq_ldiv_B!(X, lu, B, UMFPACK_Aat)
Ac_ldiv_B!{T<:UMFVTypes}(X::StridedVecOrMat{T}, lu::UmfpackLU{T}, B::StridedVecOrMat{T}) =
Ac_ldiv_B!(X::StridedVecOrMat{T}, lu::UmfpackLU{T}, B::StridedVecOrMat{T}) where {T<:UMFVTypes} =
_Aq_ldiv_B!(X, lu, B, UMFPACK_At)
A_ldiv_B!{Tb<:Complex}(X::StridedVecOrMat{Tb}, lu::UmfpackLU{Float64}, B::StridedVecOrMat{Tb}) =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get this one too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Sacha0 Sacha0 merged commit a0ada1d into JuliaLang:master May 17, 2017
@Sacha0
Copy link
Member

Sacha0 commented May 17, 2017

Gah, should've squashed. Apologies!

@musm musm deleted the patch-3 branch May 17, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman left review comments

@Sacha0 Sacha0 Sacha0 approved these changes

@andreasnoack andreasnoack andreasnoack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@musm @tkelman @Sacha0 @andreasnoack