Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #20575, syntax error for juxtaposing a string literal #21787

Merged
merged 1 commit into from
May 17, 2017

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added breaking This change will break code needs news A NEWS entry is required for this change parser Language parsing and surface syntax labels May 10, 2017
@JeffBezanson JeffBezanson removed the needs news A NEWS entry is required for this change label May 16, 2017
@JeffBezanson JeffBezanson merged commit b7d6be0 into master May 17, 2017
@JeffBezanson JeffBezanson deleted the jb/fix20575 branch May 17, 2017 03:30
@IainNZ
Copy link
Member

IainNZ commented Jul 28, 2018

Was this meant to also kill parse-time concatenation of two string literals? Its very useful for splitting long error messages over multiple lines without manually doing concatenation.

@IainNZ
Copy link
Member

IainNZ commented Jul 28, 2018

Python code but you get the point:
https://github.com/deepmind/sonnet/blob/31bc79cc9a6fe6e720e5c2402d68cc9cce2eb81c/sonnet/python/modules/conv.py#L176

On 0.6 the behaviour was

julia> x = "test""foo"
"testfoo"

julia> x = ("test"
       "foo")
ERROR: syntax: missing comma or ) in argument list

Which wasn't ideal due to the multiline case not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change will break code parser Language parsing and surface syntax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants