Unify some methods for cholesky factorizations #21595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base/linalg/cholesky.jl
Outdated
| @@ -47,6 +44,7 @@ function CholeskyPivoted{T}(A::AbstractMatrix{T}, uplo::Char, piv::Vector{BlasIn | |||
| CholeskyPivoted{T,typeof(A)}(A, uplo, piv, rank, tol, info) | |||
| end | |||
|
|
|||
| RealSymOrHerm{S} = Union{Symmetric{<:Real,S}, Hermitian{<:Any,S}} | |||
There was a problem hiding this comment.
Why not reuse the definition in Symmetric.jl?
There was a problem hiding this comment.
This? I thought that might not give the same type intersection but I guess it will?
There was a problem hiding this comment.
I guess RealHermSymComplexHerm{<:Real,<:StridedMatrix} could be used for all methods in this file then? Worth adding a type alias for that here instead?
fredrikekre
force-pushed
the
fe/cholesky
branch
from
0ea251f
to
ec88c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started to look at implementing the suggestion made here and decided to start with this unifying of some duplicated methods. (similar to what was done in #21565 )