Make TBAA for non leaftypes more precise #21308
Conversation
| if (!jl_is_datatype(jt)) | ||
| return tbaa_value; | ||
| if (jl_is_abstracttype(jt)) | ||
| return tbaa_value; |
There was a problem hiding this comment.
Since these conditions return the same thing, couldn't you just collapse them as
if (!jl_is_datatype(jt) || jl_is_abstracttype(jt))
return tbaa_value;?
There was a problem hiding this comment.
The !is_datatype branch could theoretically be made smarter, I just didn't need it here.
There was a problem hiding this comment.
Ah, okay. Does it warrant a // TODO?
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
|
Nanosoldier results look like noise. Merging. |
|
|
No description provided.