Make rowvector tests check for specific exception type #20147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix a typo that was passing because UndefVarError <: Exception
|
Thanks Tony. FYI This was already addressed in my follow-up PR #20047 (but I'm happy to rebase on this, especially for the improved formatting) |
|
whoops, didn't notice, did you add that in the most recent rebase or did I completely miss it earlier? |
|
It was last night, so about 18 hours ago, which I think is also the most recent rebase. |
|
Merging this first would be fine with me. It looks good to me. (does a +1 on the OP of a simple PR count as LGTM?) |
|
okay, if @andyferris doesn't mind rebasing then may as well merge this one now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #19670 (comment), cc @andyferris
and line wrap