Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using colon to omit a dimension in reshape #19919

Merged
merged 2 commits into from
Jan 19, 2017
Merged

Support using colon to omit a dimension in reshape #19919

merged 2 commits into from
Jan 19, 2017

Conversation

mbauman
Copy link
Member

@mbauman mbauman commented Jan 7, 2017

Closes #16790.

tkelman
tkelman reviewed Jan 7, 2017
View reviewed changes
base/reshapedarray.jl
Return an array with the same data as the given array, but with different dimensions.

The new dimensions may be specified either as a list of arguments or as a shape
tuple. Up to one dimension may be specified with a `:`, in which case its
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at most one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'd change it in the error message too)

@kshyatt kshyatt added the arrays [a, r, r, a, y, s] label Jan 8, 2017
@mbauman mbauman force-pushed the mb/reshape-colon branch 2 times, most recently from e254c01 to 2bfbb61 Compare January 8, 2017 21:41
@tkelman
Copy link
Contributor

tkelman commented Jan 16, 2017 •
edited
Loading

This would be useful, did anyone have opinions (more specific than the hooray's) on this?

@tkelman
Copy link
Contributor

tkelman commented Jan 17, 2017

just in case? @nanosoldier runbenchmarks(ALL, vs = ":master")

@tknopp
Copy link
Contributor

tknopp commented Jan 17, 2017

This is a very useful feature. So it would be great to have this for 0.6. Should be added to NEWS once merged.

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@tkelman tkelman added the needs news A NEWS entry is required for this change label Jan 17, 2017
@tkelman
Copy link
Contributor

tkelman commented Jan 18, 2017

I think those are just noise, but for good measure @nanosoldier runbenchmarks(ALL, vs = ":master")

@pabloferz
Copy link
Contributor

Those noisy results are the ones that #20025 will fix.

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@mbauman
Copy link
Member Author

mbauman commented Jan 19, 2017

NEWS.md added!

@tkelman tkelman merged commit 0724bb8 into JuliaLang:master Jan 19, 2017
@mbauman mbauman deleted the mb/reshape-colon branch January 19, 2017 18:33
@mbauman mbauman mentioned this pull request Jan 24, 2017
Closed
@Sacha0 Sacha0 removed the needs news A NEWS entry is required for this change label May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman approved these changes

Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mbauman @tkelman @tknopp @nanosoldier @pabloferz @kshyatt @Sacha0