include: deprecate multi-argument method of include #19909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Introduced in #18504. @fredrikekre any opinions if this should be kept? |
|
Oh good – then we don't even have to deprecate it, we can just delete it. Everyone I asked about the multi-argument |
StefanKarpinski
force-pushed
the
sk/include1only
branch
from
da4534b to
ae7c891
Compare
KristofferC
reviewed
Jan 6, 2017
| Evaluate the contents of the input source file(s) in the current context. Returns the result | ||
| of the last evaluated argument (of the last input file). During including, a | ||
| task-local include path is set to the directory containing the file. Nested calls to | ||
| `include` will search relative to that path. All paths refer to files on node 1 when running |
There was a problem hiding this comment.
Where did "All paths refer to files on node 1 when running in parallel, and files will be fetched from node 1." go?
There was a problem hiding this comment.
I deleted that because I made change as part of a PR to delete distributed code loading as well. I can put it back into this PR though.
Nah, just delete it :) |
This was introduced in the 0.6 release cycle, can just be deleted.
StefanKarpinski
force-pushed
the
sk/include1only
branch
from
ae7c891 to
5d5881d
Compare
|
Everyone seems peachy keen on this and it's been open for a few days so I'm pressing the button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't even realize we had this and no one seems to use it, so let's deprecate it.