Fix deprecation of quadgk to allow kwargs #19783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not worth waiting for appveyor here, thanks |
tkelman
reviewed
Dec 30, 2016
| @@ -1341,7 +1341,7 @@ end | |||
| @deprecate xor(A::AbstractArray, B::AbstractArray) xor.(A, B) | |||
|
|
|||
| # QuadGK moved to a package (#19741) | |||
| function quadgk(args...) | |||
| function quadgk(args...; kwargs...) | |||
| error(string(quadgk, args, " has been moved to the package QuadGK.jl.\n", | |||
There was a problem hiding this comment.
I'm a little surprised this somehow puts parens around the arguments like you'd want it to
There was a problem hiding this comment.
I know, I was surprised too. I copied that from another deprecation. I guess it's just because args is a tuple and calling string on a tuple gives it parens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation of
quadgkintroduced in #19741 inadvertently omitted keyword arguments from the function signature. This PR corrects that.