Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around redirection issue on windows buildbots #19619

Merged
merged 3 commits into from
Dec 17, 2016
Merged

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Dec 16, 2016

with documentation build, ref #18588 (comment)
redirecting to a file should work, but redirecting to a cygwin pipe
or driving application like perl or python (in the buildbot case) doesn't

test builds from this branch:
https://build.julialang.org/builders/package_win6.2-x64/builds/1049
https://build.julialang.org/builders/package_win6.2-x86/builds/984

vs master:
https://build.julialang.org/builders/package_win6.2-x64/builds/1045
https://build.julialang.org/builders/package_win6.2-x86/builds/980

with documentation build, ref #18588 (comment)
redirecting to a file should work, but redirecting to a cygwin pipe
or driving application like perl or python (in the buildbot case) doesn't
@tkelman tkelman added docsystem The documentation building system system:windows Affects only Windows labels Dec 16, 2016
Copy link
Member

@MichaelHatherly MichaelHatherly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Should the other rules (such as check and pdf) that get run on make release-candidate also get redirected?

@tkelman
Copy link
Contributor Author

tkelman commented Dec 16, 2016

that rule doesn't happen on the buildbots, it's a manual check

@tkelman
Copy link
Contributor Author

tkelman commented Dec 16, 2016

this might actually not be necessary? I don't see how, but #19539 apparently got things working here. closing for now, will reopen and test again if it comes back

@tkelman tkelman closed this Dec 16, 2016
@tkelman
Copy link
Contributor Author

tkelman commented Dec 16, 2016

Hm it didn't fix make cleanall && make -j4 install | tee install.log 2>&1 locally though. Jameson's suggestion from #11727 looks like it might work in a slightly less fiddly way that wouldn't be an issue to do the same thing everywhere.

@tkelman tkelman reopened this Dec 16, 2016
This reverts commit 4424c54.

Unfortunately this doesn't stop on possible failures in the doc build
@tkelman tkelman merged commit c327563 into master Dec 17, 2016
@tkelman tkelman deleted the tk/winbuildbotfix branch December 17, 2016 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docsystem The documentation building system system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants