-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #19561 (sparse map/broadcast where the output eltype is not a concrete subtype of Number) #19589
Conversation
trying not to commit to a more public |
Trying to fix this bug without sparking... extensive, peripherally related design discussion :). |
Is this mergeable? |
… concrete subtype of number.
Rewritten with #17623 and #19690 in. (This pull request now performs zero-checking via a |
Having the |
(AV x86_64 failure unrelated.) |
This pull request makes sparse
map
andbroadcast
work not only where the output eltype is a concrete subtype ofNumber
providingzero
. Specifically, this pull request handles the following cases: (1) The output eltype is concrete and either (1a) a subtype ofNumber
providingzero
or (1b) not a subtype ofNumber
but supports comparison with0
. (2) The output eltype is abstract, but each output value either is (2a) of a subtype ofNumber
providingzero
or (2b) not of a subtype ofNumber
but supports comparison with0
. Fixes #19561. Best!