Fix \ and .'\ for Symmetric and Hermitian sparse matrices. #19242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
added
linear algebra
tkelman
reviewed
Nov 6, 2016
| @@ -670,3 +671,19 @@ let m = 400, n = 500 | |||
| @test s.is_super == 0 | |||
| @test F\b ≈ ones(m + n) | |||
| end | |||
|
|
|||
| # Test that \ and '\ and .'\ work for Symmetric and Hertian. This is just | |||
tkelman
reviewed
Nov 6, 2016
| @@ -670,3 +671,19 @@ let m = 400, n = 500 | |||
| @test s.is_super == 0 | |||
| @test F\b ≈ ones(m + n) | |||
| end | |||
|
|
|||
| # Test that \ and '\ and .'\ work for Symmetric and Hertian. This is just | |||
| # a dispatch excercise so it doesn't matter that the complex matrix have | |||
andreasnoack
force-pushed
the
anj/spsyhe
branch
from
646fe45 to
4a2e134
Compare
ararslan
reviewed
Nov 7, 2016
| @@ -57,6 +57,10 @@ for f in (:A_ldiv_B!, :Ac_ldiv_B!, :At_ldiv_B!) | |||
| $f(A, copy!(Y, B)) | |||
| end | |||
|
|
|||
| # fallback methods for transposed solves | |||
| At_ldiv_B{T<:Real}(F::Factorization{T}, B) = Ac_ldiv_B(F, B) | |||
There was a problem hiding this comment.
This appears to be the cause of ambiguity errors
|
What's the status on this? |
andreasnoack
force-pushed
the
anj/spsyhe
branch
from
4a2e134 to
484aee4
Compare
|
There was an ambiguity. I've resolved it so the PR should be ready when the tests complete. |
andreasnoack
force-pushed
the
anj/spsyhe
branch
from
484aee4 to
d433e6f
Compare
|
There was actually another problem. |
Undeprecate conj for sparse matrices.
andreasnoack
force-pushed
the
anj/spsyhe
branch
from
d433e6f to
3df361b
Compare
tkelman
pushed a commit
that referenced
this pull request
Feb 22, 2017
(cherry picked from commit d9d0fad)
fcard
pushed a commit
to fcard/julia
that referenced
this pull request
Feb 28, 2017
…#19242) Undeprecate conj for sparse matrices.
This was referenced May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, we were not testing
\forSymmetricandHermitiansparse matrices. We also didn't have a fallback method forA.'\b. See also JuliaLang/LinearAlgebra.jl#384