-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check freshness of doc/stdlib on Travis #18815
Conversation
The error this has found immediately has been fixed in 38a63bd (38a63bd#diff-1b93b2bd585f1eb42df445590f059fdcR1643). |
It's a little too easy to miss why the build failed here. Should probably terminate the job immediately and not run the tests when this happens. |
Hm, I couldn't find a way to make Travis terminate the job. Doing this test last might be a viable alternative. |
6fb10ed
to
2888898
Compare
Waiting until the very end to run this is going to eat up a lot of CI time. Simple, not especially elegant workaround would be to touch a file as a flag if this check succeeds, and skip running the tests to save CI time (but still flag the build as a failure) if it's not present. |
I had something like that using an environment variable, similar to |
2888898
to
0da7bfc
Compare
0da7bfc
to
a73dddb
Compare
Comments on the current status? |
Bumping. |
Bump. |
I think #18588 is close enough to merging that this is soon to be made obsolete. This yml file is already pretty complicated and hard to read as is. |
Fair enough. I'll leave this open for now in case some unexpected problem comes up in #18588. |
Superseded by #18588. |
Will be obsoleted by #18588 but hopefully is useful until then by catching the common mistake of modifying docstrings and not updating the corresponding RST files.