Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore getfield deprecation for foo.(1) etc. #17773

Merged
merged 2 commits into from
Aug 3, 2016

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Aug 3, 2016

This restores the deprecation warning for object.(i) when i is a literal integer, which was accidentally broken by #17318 #17300 as noticed by @tkelman.

(I'm not sure how to do a regression test for a deprecation warning. 😕)

@stevengj stevengj added this to the 0.5.0 milestone Aug 3, 2016
@tkelman
Copy link
Contributor

tkelman commented Aug 3, 2016

Thanks! BTW, are the M.(:+) and M.(1) deprecations mentioned in NEWS?

edit: M.(:+) is, but M.(1) isn't from what I could find while doing #17779

@stevengj
Copy link
Member Author

stevengj commented Aug 3, 2016

Yeah, probably M.(1) should be mentioned as well.

@stevengj
Copy link
Member Author

stevengj commented Aug 3, 2016

I fixed the NEWS for M.(1) in 47d522f.

@stevengj
Copy link
Member Author

stevengj commented Aug 3, 2016

Okay to merge?

@tkelman
Copy link
Contributor

tkelman commented Aug 3, 2016

Looks reasonable to me, but what the rest of the compress-fuse (that isn't being changed) accomplishes goes a little bit over my head. If Jeff approves?

@stevengj
Copy link
Member Author

stevengj commented Aug 3, 2016

cc @JeffBezanson

@JeffBezanson JeffBezanson merged commit de762cd into JuliaLang:master Aug 3, 2016
@stevengj stevengj deleted the getfield-deprecation branch August 3, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants