Revert "LibGit2: added tree related functions & tests" #17409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| if fnc !== nothing | ||
| @eval function Base.finalize(obj::$typ) |
There was a problem hiding this comment.
Unrelated to this PR but I don't think Base.finalize should be overloaded.
There was a problem hiding this comment.
finalize has a well defined meaning of calling the finalizer and remove that from the finalizer list. This overload doesn't do that.
|
I have no idea why macOS build fails on these tests. |
|
We can reopen a branch if that makes it easier for anyone to test and try to reproduce |
|
I'll create branch in julia repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #16537
causing segfaults on osx travis, whoops
cc @wildart, anyone else have ideas what might be wrong?