disable gcroot creation for a value with an existing root #17379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when loading a value from a struct that didn't need a local gcroot, the loaded value also doesn't require a gcroot if the struct was immutable fix #17342
|
Thank you!! |
| @@ -1033,7 +1033,7 @@ static bool emit_getfield_unknownidx(jl_cgval_t *ret, const jl_cgval_t &strct, V | |||
| builder.CreateGEP(data_pointer(strct, ctx), idx))); | |||
| if ((unsigned)stt->ninitialized != nfields) | |||
| null_pointer_check(fld, ctx); | |||
| *ret = mark_julia_type(fld, true, jl_any_type, ctx, true); | |||
| *ret = mark_julia_type(fld, true, jl_any_type, ctx, strct.gcroot || !strct.isimmutable); | |||
There was a problem hiding this comment.
Just to make sure, can this handle strct being reassigned later?
e.g.
for i in rng
x = return_immutable()
cond && y = x.field
end
use(y)
There was a problem hiding this comment.
cgval (and thus this gcroot field) should be ssa. in your example above, the gcroot should have been created for x, and thus non-null, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when loading a value from a struct that didn't need a local gcroot,
the loaded value also doesn't require a gcroot if the struct was immutable
fix #17342