Fixes 2 issues with the Cholesky update/downdate tests #17199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. It was possible to get random matrices which would not be positive definite when down-dated (e.g. if I ran the block with `srand(1)`. I have no idea how this didn't become an issue more often. 2. Apparently `v*v'` isn't Hermitian when using the system BLAS on Power.
simonbyrne
added
test
| F = cholfact(AcA, uplo) | ||
| @test LinAlg.lowrankupdate(F, v)[uplo] ≈ cholfact(AcA + v*v')[uplo] |
There was a problem hiding this comment.
Maybe cholfact(Hermitian(AcA + v*v')) instead of cholfact(BcB).
There was a problem hiding this comment.
julia> cholfact(Hermitian(AcA + v*v'))
ERROR: ArgumentError: Cannot construct Hermitian from matrix with nonreal diagonals
There was a problem hiding this comment.
Arrrr... I'd forgotten that we still do that. That check should go away.
|
Ah, thanks, this is an issue on AArch64 (with OpenBLAS) too. |
|
FMAs seem to be the issue here. It makes complex multiplication non-commutative. |
Yikes. That's not good at all. Is there an issue for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srand(1). I have no idea how this didn't become an issue more often.v*v'isn't Hermitian when using the system BLAS on Power.cc: @andreasnoack @vtjnash