WIP: Towards #12251 part 3, deprecate full and remove related exports and docs #17082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
changed the title
|
Rebased with #17066 and #17079 merged, but added the WIP tag as this pull request needs revision and expansion: Addressing #17066 (comment) and #17066 (comment) / #17066 (comment) alongside deprecation of |
| @@ -622,8 +622,6 @@ convert{T,S,N}(::Type{AbstractArray{T }}, A::AbstractArray{S,N}) = convert(Abst | |||
|
|
|||
| convert{T,N}(::Type{Array}, A::AbstractArray{T,N}) = convert(Array{T,N}, A) | |||
|
|
|||
| full(x::AbstractArray) = x | |||
22 tasks
|
With #12153 on the 1.0 milestone, perhaps this PR should receive a 1.0 tag as well? |
tkelman
added
the
kind:deprecation
|
Closing as out-of-date. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last step towards #12251 (for a description of the overall objective and plan, see #17066 (comment)). This pull request deprecates all
fullmethods and removes related exports and docs. Thanks and best!