-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julia 0.4.6 backport of #15334 #16990
Julia 0.4.6 backport of #15334 #16990
Conversation
can you add the cross-reference to the original commit sha and PR # in the commit message? thanks |
Millisecond(v) | ||
|
||
.. Docstring generated from Julia source | ||
.. data:: Year(v) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this supposed to be data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original PR did switch it from function to data. Worth noting that all those functions do have docstrings attached.
I think I backported that in my branch? |
- Added documentation for Dates.format - Added documentation for date accessors - Eliminated cross-referencing similar to: "see above" - Sync date accessor docstrings with manual - Fixed signatures of certain Period constructors. Hour, Minute, Second and Millisecond would always fail when a Date was given as an argument (cherry picked from commit c26cfa7) ref JuliaLang#15334
a14441e
to
3be0d25
Compare
I'm working off of your branch (currently 7d54836). When running
If/when Markdown tables get backported I'll happily update this PR to use the Markdown tables. |
I was thinking of c47090d - so is genstdlib broken in some way here? |
The issue with I don't think we need to fix genstdlib here. I'm fine with just using an RST table for the backport but if we decide to backport Markdown table support I can switch this documentation back to using Markdown tables. |
The original PR didn't backport cleanly as
base/docs/helpdb/Dates.jl
didn't exist on 0.4 and Markdown tables were not supported.