Replace '\\' with '/' for Windows filenames in Base.url #16858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
changed the title
tkelman
changed the title
tkelman
force-pushed
the
tk/urlbackslash
branch
3 times, most recently
from
a14f2d4 to
228f5fe
Compare
Backslashes aren't valid urls, and this happens to also fix the outside-of-base code below that uses libgit2 since `LibGit2.path` always uses forward slashes (behavior inherited from the underlying `git_repository_path` function) Temporary directories used by tests are inside a symlink on mac, so use realpath in startswith check
Contributor
Author
|
Apparently OS X temporary directories are under a symlink, so thanks to Travis I found and fixed a third bug in this same bit of code. |
Member
|
Can this be merged now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backslashes aren't valid in urls, and this happens to also fix the outside-of-base
code below that uses libgit2 since
LibGit2.pathalways uses forward slashes(behavior inherited from the underlying
git_repository_pathfunction)wip until I write some tests to cover the cases this fixes