Fix some documentation and deprecation issues #16585
Conversation
|
Those table entries can just be removed (whether before or after the deprecation is removed, I don't know). They won't occur in ASTs any more. |
|
I think it's probably best to remove documentation at the same time as deprecating something, otherwise it'll sit there for who knows how long. Removing deprecations is usually a deletion of a big chunk of code, and it's too easy to skip the part about searching carefully through any remaining mentions of what you're deleting. |
why weren't these causing warnings?
add quotes around (0,0) Adjust grammar in some comments and docstrings
see discussion in JuliaLang#16561, deprecations should be flagged, found, and removed in base - if you need to include code with deprecations in userimg.jl, then add --depwarn=no manually when building that custom image
tkelman
force-pushed
the
tk/docfixes
branch
2 times, most recently
from
334d659 to
cdc9e62
Compare
there are a few more in the FFTW deprecations that should be removed soon
msync, iseltype, inf, nan, complement, complement! etc etc etc
|
Review appreciated, will merge later if no objections. |
|
👍 Very nice. |
|
Our various deprecation sprees may have a few conflicts. And https://github.com/tkelman/julia/blob/60c269d9e38f0416635cef8d7e543dcc54bd98b4/base/deprecated.jl#L504-L509 will give a warning ( |
|
Yeah, that's fine. |
ref #16561
the dict comprehension is still mentioned in the table at https://github.com/tkelman/julia/blob/d538f2920a5a9b7e0e70280a419e2f5e8fb9772a/doc/devdocs/ast.rst#bracketed-forms, I'm not sure what to replace it with