Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move number-related files to numbers directory #16557

Closed
wants to merge 1 commit into from
Closed

Conversation

simonbyrne
Copy link
Contributor

Okay, this is a bit of a bike shed, but the number of files in base means that it is starting to get difficult to navigate. There is perhaps room for discussion as to which files should be moved where, but I figured this seemed like a good start.

I've intentionally left out primes.jl, pending #16481.

@JeffBezanson
Copy link
Member

Agree with the direction, but I think it would be better to isolate pieces that could actually become separate modules or packages, per the discussion in #16357.

@StefanKarpinski
Copy link
Member

Doesn't this seem like a good first step in that direction?

@JeffBezanson
Copy link
Member

I don't really see how, since most of this code will never be removed from Base.

@simonbyrne
Copy link
Contributor Author

So if it's going to remain in Base, doesn't make sense to keep it somewhat organised?

@JeffBezanson
Copy link
Member

It could, but personally I find lots of directories more annoying, unless they represent really obvious components. Thinking about it as "these files could form a separate package" is likely to be a good test for whether the organization is useful.

Looking at it, I see we have several bits that have both a file and a directory, e.g. both pkg and pkg.jl, sparse and sparse.jl. I think x.jl should be moved into x/ in these cases, which will help clean up the base directory a bit.

@quinnj
Copy link
Member

quinnj commented May 25, 2016

Yeah, I did the same thing for the dates/ directory and the base/Dates.jl file, the distinction being the base/Dates.jl file is what sysimg.jl knows about, and includes all the include("dates/.") commands. I think it's fine moving it into the dates/ directory, but I thought of it more as the "Base interface" file or a breadcrumb to where the Dates.jl code is coming from.

@oscardssmith
Copy link
Member

Possibly a good idea, but if we wanted this, it would be easier to make a new PR from scratch.

@DilumAluthge DilumAluthge deleted the sb/rearrange branch August 24, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants