Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate histogram functionality #16450

Merged
merged 4 commits into from
May 27, 2016
Merged

deprecate histogram functionality #16450

merged 4 commits into from
May 27, 2016

Conversation

simonbyrne
Copy link
Contributor

Updated PR from #6842

@simonbyrne simonbyrne added this to the 0.5.0 milestone May 19, 2016
@tkelman
Copy link
Contributor

tkelman commented May 19, 2016

I think the exports for these should probably also be moved from exports.jl to near their definitions in deprecated.jl

@simonbyrne simonbyrne force-pushed the sb/histdep branch 4 times, most recently from 1f7d843 to aaae574 Compare May 26, 2016 10:03
@@ -334,17 +334,23 @@ for rng in ([], [MersenneTwister()], [RandomDevice()])
end
end

function hist(X,n)
v = zero(Int,n)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zeros ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right.

@tkelman tkelman merged commit bc56e32 into master May 27, 2016
@tkelman tkelman deleted the sb/histdep branch May 27, 2016 12:01
@tkelman
Copy link
Contributor

tkelman commented Aug 3, 2016

@simonbyrne
Copy link
Contributor Author

No, I don't think so; the change looks good.


## midpoints of intervals
midpoints(r::Range) = r[1:length(r)-1] + 0.5*step(r)
midpoints(v::AbstractVector) = [0.5*(v[i] + v[i+1]) for i in 1:length(v)-1]
Copy link
Contributor

@tkelman tkelman Jan 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were missing depwarns - they're still exported and tested...

tkelman added a commit that referenced this pull request Jan 16, 2017
and actually deprecate it - this was moved to deprecated.jl
in #16450, but not actually deprecated
tkelman added a commit that referenced this pull request Jan 17, 2017
and actually deprecate it - this was moved to deprecated.jl
in #16450, but not actually deprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants