Use similar+copy! instead of copy_oftype for AbstractMatrix #16288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid infinite compilation recursion.
| @@ -39,6 +39,9 @@ for t in (:LowerTriangular, :UnitLowerTriangular, :UpperTriangular, | |||
| end | |||
| end | |||
|
|
|||
| LowerTriangular(U::UpperTriangular) = throw(ArgumentError("this shouldn't happen. Please submit a bug report")) | |||
| UpperTriangular(U::LowerTriangular) = throw(ArgumentError("this shouldn't happen. Please submit a bug report")) | |||
There was a problem hiding this comment.
I don't think this is quite right, a user could easily call the constructors to try to do this. Maybe something like "Cannot create an UpperTriangular matrix from a LowerTriangular input"?
There was a problem hiding this comment.
Yes. That is probably better. I'll update the error message.
to make sure that copy is mutable. Fixes #15401
andreasnoack
force-pushed
the
anj/mutablecopy
branch
from
a827aec to
ec31d50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw error for
LowerTriangular(::UpperTriagular)and vice versa to avoid infinite compilation recursion.Use
similar+copy!instead ofcopy_oftypeforAbstractMatrixarguments to make sure that the copy is mutable. Fixes JuliaLang/LinearAlgebra.jl#316This also kind of fixes #16201 since it doesn't hang anymore.