-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify mapreduce_impl #16217
simplify mapreduce_impl #16217
Conversation
I don't think we should close #16185 until the reduced example I posted there is fixed. Alternatively a new issue could be made for that example. |
The reduced example in that issue might not get fixed. The extra code allows dynamic dispatch to a version of |
From triage call:
|
TODO: there should be a note in NEWS about the changed reduction order. |
We should definitely keep both pairwise summation and the 0.4 level of performance. If necessary we should manually specialize |
this is possible now that Functors are not needed for performance fixes #16185
fbaa2c0
to
cbd77c2
Compare
Apparently DataArrays was using |
it can define |
That's what I did in JuliaStats/DataArrays.jl#192. If that was the only use of it outside of Base, I guess that's OK. |
NullableArrays was also using it. |
this is largely now possible since Functors are not needed for performance
fixes #16185