Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster subarray tests with ANY #15999

Merged
merged 1 commit into from
Apr 22, 2016
Merged

Faster subarray tests with ANY #15999

merged 1 commit into from
Apr 22, 2016

Conversation

timholy
Copy link
Member

@timholy timholy commented Apr 22, 2016

There's no need to compile many of the test functions for the bazillion different subarray types, so let's use ANY in the tests.

Master:

julia> @time include("subarray.jl")
425.944279 seconds (221.28 M allocations: 8.740 GB, 1.24% gc time)

This PR:

julia> @time include("subarray.jl")
282.632151 seconds (146.17 M allocations: 5.896 GB, 2.29% gc time)

@timholy timholy mentioned this pull request Apr 22, 2016
@timholy
Copy link
Member Author

timholy commented Apr 22, 2016

Hmm, OSX has now timed out twice. AFAICT this is happening after the main tests finish successfully, and the libgit2 tests are running. But the output for OSX seems to have changed recently, so I'm not sure I'm reading it correctly.

@JeffBezanson
Copy link
Member

OSX is timing out a lot lately.

@timholy
Copy link
Member Author

timholy commented Apr 22, 2016

OK, so I'll assume this can't be making it worse and just merge this.

@timholy timholy merged commit c204232 into master Apr 22, 2016
@timholy timholy deleted the teh/faster_subarray_tests branch April 22, 2016 16:41
@mbauman
Copy link
Member

mbauman commented Apr 22, 2016

OS X doesn't even run the subarray tests these days — it's just a minimal subset of tests to try to stay within the time limit. Thanks Tim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants