Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix float16 test #15994

Merged
merged 1 commit into from
Apr 22, 2016
Merged

Fix float16 test #15994

merged 1 commit into from
Apr 22, 2016

Conversation

yuyichao
Copy link
Contributor

Do not use rand() and test both round up and down in different functions.

Closes #15993

@yuyichao
Fix float16 test
6612826 
Do not use `rand()` and test both round up and down in different functions.

Closes #15993
@yuyichao yuyichao added test This change adds or pertains to unit tests backport pending 0.4 labels Apr 21, 2016
@yuyichao yuyichao merged commit e76298b into master Apr 22, 2016
@yuyichao yuyichao deleted the yyc/tests/float16trunc branch April 22, 2016 14:56
@kshyatt
Copy link
Contributor

kshyatt commented Apr 22, 2016

@yuyichao thanks for fixing this!

tkelman pushed a commit that referenced this pull request Jun 17, 2016
@yuyichao @tkelman
Fix float16 test
3846eb4 
Do not use `rand()` and test both round up and down in different functions.

Closes #15993

(cherry picked from commit 6612826)
ref #15994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuyichao @kshyatt @tkelman