Yet more random tests #15794
Yet more random tests #15794
Conversation
| @@ -68,3 +68,5 @@ for elty in (Float32,Float64) | |||
| @test round(elty2,A) == fill(round(elty2,x),(10,10,10)) | |||
| end | |||
| end | |||
|
|
|||
| @test float(Char) == Any | |||
There was a problem hiding this comment.
Well, the function is defined here.
There was a problem hiding this comment.
what would break if we got rid of it?
There was a problem hiding this comment.
That may be a vestige from when Char was a type of number. It isn't anymore, so we should delete this definition.
|
Hopefully I did the right thing here... |
|
you'll also need to get rid of your test for it, I would assume |
|
@tkelman better? |
|
The float method was introduced in #14413 (quite recently), and seems to still be in use (although untested). cc @simonbyrne PS: There seems to be some confusion in the comments here because @kshyatt tested |
|
whoops, should have checked blame. and there should've been a test that needed it? what does the Any result allow that to do though? |
No description provided.