Test return as expression
#15548
Merged
Test return as expression
#15548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschnett
force-pushed
the
eschnett/return
branch
from
3cf8498
to
6ff724d
Compare
|
needs end-of-file rebase but lgtm |
eschnett
force-pushed
the
eschnett/return
branch
from
6ff724d
to
ea8c89e
Compare
|
|
||
| # issue #11169 | ||
| @test_throws UndefVarError undefvar | ||
| let undefvar = return end |
There was a problem hiding this comment.
This is a bit sketchy --- it's not clear we should even allow return without any obvious enclosing function. Also since this is a let, it wouldn't lead to undefvar being defined globally anyway. Maybe we should test f(return) and confirm that f wasn't called (via a side effect)?
There was a problem hiding this comment.
I think this should succeed:
uncalled(x) = @test false
fret() = uncalled(return true; @test false)
@test fret()Alas it doesn't; the @test false after the return true is executed. This looks like a bug to me.
There was a problem hiding this comment.
Yes I think you're right. I believe this is #9535.
eschnett
force-pushed
the
eschnett/return
branch
from
53dad23
to
edf5ba1
Compare
|
@JeffBezanson I simplified the test -- nothing about argument order any more. LGTY? |
JeffBezanson
added a commit
that referenced
this pull request
Mar 22, 2016
Test `return` as expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11169.