Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "sidebars" for markdown tables. #15530

Merged

Conversation

MichaelHatherly
Copy link
Member

Adds | columns on each side of markdown tables to avoid trailing whitespace problems in rendered documents. This is still valid markdown.

This does not change the parsing of markdown tables, which can still be written without the | columns on each side.

Adds `|` columns on each side of markdown tables to avoid trailing
whitespace problems in rendered documents. This is still valid markdown.

This does not change the parsing of markdown tables, which can still
be written without the `|` columns on each side.
@tkelman
Copy link
Contributor

tkelman commented Mar 16, 2016

lgtm!

@MichaelHatherly
Copy link
Member Author

Thanks for reviewing.

Potentially worth backporting? Ref: JuliaDocs/Documenter.jl#29.

MichaelHatherly added a commit that referenced this pull request Mar 17, 2016
…ering

Use "sidebars" for markdown tables.
@MichaelHatherly MichaelHatherly merged commit fb283c6 into JuliaLang:master Mar 17, 2016
@MichaelHatherly MichaelHatherly deleted the mh/markdown-table-rendering branch March 17, 2016 08:49
tkelman pushed a commit that referenced this pull request Jun 17, 2016
Adds `|` columns on each side of markdown tables to avoid trailing
whitespace problems in rendered documents. This is still valid markdown.

This does not change the parsing of markdown tables, which can still
be written without the `|` columns on each side.

(cherry picked from commit 14a4fed)
ref #15530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants