Remove at-init from docsystem.
#15237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces macro init with a function instead. Appears to reduce the amount of code generated by `at-doc` which should help shorten bootstrapping time slightly. Also changes the name of the `ObjectIdDict` used to store docstrings to a gensym'd one to avoid naming clashes. `Docs.meta` has always been available to access this const without needing to know it's name so this shouldn't be a major breaking change.
|
+1 |
tkelman
added a commit
that referenced
this pull request
Feb 26, 2016
Remove `at-init` from docsystem.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces macro
@initwith a function instead. Appears to reduce the amount of code generated by@docwhich should help shorten bootstrapping time slightly.Also changes the name of the
ObjectIdDictused to store docstrings to a gensym'd one to avoid naming clashes.Docs.metahas always been available to access this const without needing to know it's name so this shouldn't be a major breaking change.