Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issparse for specialized matrix types part of #13096 #15179

Merged
merged 1 commit into from
Feb 23, 2016

Conversation

pkofod
Copy link
Contributor

@pkofod pkofod commented Feb 21, 2016

Adds issparse methods for specialized matrix types, such that it returns true if the matrix they are based on are sparse.

cc @kshyatt

@ViralBShah ViralBShah added the sparse Sparse arrays label Feb 21, 2016
@tkelman
Copy link
Contributor

tkelman commented Feb 22, 2016

Looks reasonable. Could you rebase and squash the commits?

@pkofod
Copy link
Contributor Author

pkofod commented Feb 22, 2016

Yes, although I seem to have done something wrong :)

@tkelman
Copy link
Contributor

tkelman commented Feb 22, 2016

Yeah, this shouldn't have the other commit from a different PR in it. If you rebase again but delete the line for that other commit it should fix it.

@pkofod
Copy link
Contributor Author

pkofod commented Feb 22, 2016

Sigh, I always mess this rebase-thing up. I need to find a git course :)

When you say "rebase again but delete the line for that other commit" what do you mean by that ? (by the way I seem to have added another commit now.

Edit: I seem to have figured it out :)

tkelman added a commit that referenced this pull request Feb 23, 2016
Address issparse for specialized matrix types part of #13096
@tkelman tkelman merged commit 6f2ac3c into JuliaLang:master Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sparse Sparse arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants