RFC: Reverse order of outputs from enumerate, to emulate python. (fix #1430) #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
+1 |
Member
|
Seems like a good idea to me to make it more consistent with python. |
Member
|
3a0e570 added some enumerate tests; could you also add a commit updating them? |
Member
|
Actually no, the tests I added are for the BTW I also support this change. |
Member
|
Oops. Anyway, these are the tests i meant. |
Member
|
Yikes, i clearly need more coffee. The test changes are already part of the commit. Merged. |
nolta
added a commit
that referenced
this pull request
Oct 25, 2012
RFC: Reverse order of outputs from enumerate, to emulate python. (fix #1430)
ViralBShah
added a commit
that referenced
this pull request
Jan 10, 2026
Stdlib: LinearAlgebra URL: https://github.com/JuliaLang/LinearAlgebra.jl.git Stdlib branch: master Julia branch: master Old commit: b599095 New commit: 0eaade8 Julia version: 1.14.0-DEV LinearAlgebra version: 1.13.0 (Does not match) Bump invoked by: @ViralBShah Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaLang/LinearAlgebra.jl@b599095...0eaade8 ``` $ git log --oneline b599095..0eaade8 0eaade8 In-place multiplication of `Diagonal` with OffsetMatrix should throw (#1526) 417e914 Reduce method definitions for cat of `AbstractQ`s (#1500) 653ead1 Make sure inputs to the hemm etc tests are Hermitian (#1522) 4004db9 fix typos (#1521) eb007bb Fix GEMM dispatch for complex-real matmul (#1520) f41bf65 Fix unitful 3-arg `*` (#1499) 24ac8e9 Bump actions/checkout from 5 to 6 (#1518) 2a6f3b7 make eigvals(::Diagonal) accept sortby (#1477) 189d49d Make `dot` consistently return `zero` on empty arrays (#1494) 1c0b673 Ensure inverse of Symmetric{<:,Diagonal} returns same type (#1439) fa00b3c Fixed typo in matmul.jl (#1492) 21af0af Fix 3-arg `dot` for empty arrays (#1485) 6beb32c Make matmul work with zero-less eltypes (#1488) ``` Co-authored-by: ViralBShah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #1430. Changes usage from e g
to
RFC: This change will break any code outside the julia repo that uses
enumerate,but will make it consistent with Python. Any objections to merging this now?