Add some tests in printf.jl for BigFloat #12884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @test( @sprintf( "%#10.5g", 123.4 ) == " 123.40") | ||
| @test( @sprintf( "%-10.5g", 123.4 ) == "123.4 ") | ||
| @test( @sprintf( "%-+10.5g", 123.4 ) == "+123.4 ") | ||
| for (val, res) in ((12345678., "1.23457e+07"), (1234567.8, "1.23457e+06"), (123456.78, "123457"), (12345.678, "12345.7"), (12340000.0, "1.234e+07")) |
There was a problem hiding this comment.
There were zero line breaks in the original file, I can add them before the sections (where there are # comments) if you think it would make it easier to read.
There was a problem hiding this comment.
All I see is that before it was easy to read now it is hard. Lining up the tuples would imho make it nicer. Similarly to
Line 173 in 349a4e1
There was a problem hiding this comment.
Ah, thanks, that's a good suggestion. I was just striving for code coverage.
Better format test code
ScottPJones
force-pushed
the
spj/printf
branch
from
80f5c6f to
113e9e5
Compare
|
@KristofferC Hopefully you like this even better than the original file. Thanks for the suggestion! Anything else to make it better? |
|
Once again, the OOM killer strikes! Nothing to do with my changes though. |
jakebolewski
added a commit
that referenced
this pull request
Sep 1, 2015
Add some tests in printf.jl for BigFloat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added BigFloat tests, make the code a bit more general.