Breaking change, but minor(?) for countlines()

[PallHaraldsson]

I'm not sure this is the right place to put this. Didn't notice a section on breaking changes. Linked issue, has different title, but its second commit is on this, to docs. Should you not link issues, not that directly? I didn't find another correct issue number. Countlines has parameters, e.g. for the new, for empty lines. Should all (or any) be listed?

[pao]

...continuing from the other issue, as you may have figured out: putting [ci skip] in the issue title is ineffective. :D

[lostanlen]

Why should you put commas before and after the words "non-empty lines" ?

[PallHaraldsson]

The commas may be overkill or just plain wrong here..

Is this correct: "now also counts non-empty lines, by default"?

with one comma looked wrong to me but maybe isn't.. Similarly, I would say "By default, countlines() counts non-empty-lines".

English (and my native language) use fewer commas than previously (was taught, when I was young..), but I think you are still allowed to use more, just a preference.

If you want "now also counts non-empty lines by default", I think I can change the commit that way.

I' a little confused by:

ARCH="x86_64"

in the Travis CI build fail.

[KristofferC]

The Travis CI failure is due to running out of memory and it has nothing to do with your change.

I am also not a native speaker but for me it sounds best with no commas.

[PallHaraldsson]

Thanks, I see this was added, but to be useful to people, shouldn't it be added to v0.4.0-rc2? I think (as with similar situations), stuff committed to master, will not show up in 0.4.0* end the eventual released 0.4.0(?).

[tkelman]

it was backported here ddee103 and will be in rc3